Subject: virt-install: Reuse cli.fail_conflicting From: Cole Robinson crobinso@redhat.com Mon Aug 22 10:15:46 2022 -0400 Date: Mon Aug 22 10:16:19 2022 -0400: Git: 1d64a678d31829051444e1bf29d86f800e13de39 For the --unattended + --cloud-init conflict Signed-off-by: Cole Robinson --- a/tests/test_cli.py +++ b/tests/test_cli.py @@ -1116,7 +1116,7 @@ c.add_invalid("--disk none --boot networ c.add_invalid("--nodisks --boot network --arch mips --virt-type kvm", grep="any virtualization options for architecture 'mips'") c.add_invalid("--nodisks --boot network --paravirt --arch mips", grep=" 'xen' for architecture 'mips'") c.add_invalid("--osinfo generic --launchSecurity sev --connect " + utils.URIs.kvm_amd_sev, grep="SEV launch security requires a Q35 UEFI machine") -c.add_invalid("--disk none --cloud-init --unattended --install fedora30", grep="--unattended and --cloud-init can not") +c.add_invalid("--disk none --cloud-init --unattended --install fedora30", grep="Cannot use --unattended and --cloud-init at the same time") --- a/virtinst/virtinstall.py +++ b/virtinst/virtinstall.py @@ -412,7 +412,7 @@ def build_installer(options, guest, inst extra_args = [installdata.kernel_args] if options.unattended and options.cloud_init: - fail("--unattended and --cloud-init can not be specified together.") + cli.fail_conflicting("--unattended", "--cloud-init") if options.unattended: unattended_data = cli.parse_unattended(options.unattended)